Merged
Conversation
uses x:Bind now Removed unnecessary Uno features. Updated to .net 9
Collaborator
|
Thanks - I will run through the process tomorrow (or maybe this afternoon if I free up some time) and get it integrated. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 68 out of 83 changed files in this pull request and generated no comments.
Files not reviewed (15)
- samples/todoapp/TodoApp.Uno/.editorconfig: Language not supported
- samples/todoapp/TodoApp.Uno/.run/TodoApp.Uno.run.xml: Language not supported
- samples/todoapp/TodoApp.Uno/.vscode/extensions.json: Language not supported
- samples/todoapp/TodoApp.Uno/.vscode/launch.json: Language not supported
- samples/todoapp/TodoApp.Uno/.vscode/settings.json: Language not supported
- samples/todoapp/TodoApp.Uno/.vscode/tasks.json: Language not supported
- samples/todoapp/TodoApp.Uno/.vsconfig: Language not supported
- samples/todoapp/TodoApp.Uno/Directory.Build.props: Language not supported
- samples/todoapp/TodoApp.Uno/Directory.Build.targets: Language not supported
- samples/todoapp/TodoApp.Uno/Directory.Packages.props: Language not supported
- samples/todoapp/TodoApp.Uno/TodoApp.Uno.sln: Language not supported
- samples/todoapp/TodoApp.Uno/TodoApp.Uno/App.xaml: Language not supported
- samples/todoapp/TodoApp.Uno/.run/Readme.md: Evaluated as low risk
- samples/todoapp/TodoApp.Uno/TodoApp.Uno/GlobalUsings.cs: Evaluated as low risk
- samples/todoapp/TodoApp.Uno/TodoApp.Uno/Assets/SharedAssets.md: Evaluated as low risk
Comments suppressed due to low confidence (1)
samples/todoapp/TodoApp.Uno/TodoApp.Uno/Database/TodoItem.cs:11
- The
Titleproperty should be marked as nullable or have a default value to avoid potential null reference issues.
public string Title { get; set; } = string.Empty;
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for just getting back on this.
I re-added the LoggingHandler. It was removed due to an oversight as I was trying to clean out unnecessary files.
I also fixed the ProgressBar bug by specifying
Mode=OneWayin the binding. I'm not sure why this isn't needed in the WinUI app.I tried various methods of adding the Uno project to the samples solution, but was unsuccessful. I know Uno requires the project & solution to be in the same folder, so it may be due to that. I played with the folder structure, but it seemed to cause more problems than it solved.